Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Clean up unused bloom filter related code #14183

Merged
merged 6 commits into from
Sep 19, 2024
Merged

chore: Clean up unused bloom filter related code #14183

merged 6 commits into from
Sep 19, 2024

Conversation

chaudum
Copy link
Contributor

@chaudum chaudum commented Sep 19, 2024 •
edited
Loading

What this PR does / why we need it:

This PR tries to eliminate dead code in the bloom package, mainly related to line tokenization.

Special notes for your reviewer:

The binary encoding of the Schema object has been kept "backwards" compatible. Should we drop that?

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@chaudum chaudum requested a review from a team as a code owner September 19, 2024 13:44
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Sep 19, 2024
rfratto
rfratto approved these changes Sep 19, 2024
View reviewed changes
pkg/validation/limits.go Show resolved Hide resolved
@rfratto
Copy link
Member

rfratto commented Sep 19, 2024

The binary encoding of the Schema object has been kept "backwards" compatible. Should we drop that?

This would only impact our existing deployment, right? It's very little overhead so I don't think it matters, but it might be nice to remove it now while we have a chance as long as it wouldn't cause too much pain.

@chaudum
Copy link
Contributor Author

chaudum commented Sep 19, 2024

The binary encoding of the Schema object has been kept "backwards" compatible. Should we drop that?

This would only impact our existing deployment, right?

Right.

It's very little overhead so I don't think it matters, but it might be nice to remove it now while we have a chance as long as it wouldn't cause too much pain.

Ok, let's remove it. It means that existing V3 blocks cannot be read any more and should be deleted from object storage.

@chaudum
Remove n-gram length and n-gram skip
7f6bf48 
Signed-off-by: Christian Haudum <[email protected]>
@chaudum
Remove ngram bloom tester
05e5d45 
Signed-off-by: Christian Haudum <[email protected]>
@chaudum
Remove ngram tokenizer
b53b846 
Signed-off-by: Christian Haudum <[email protected]>
@chaudum
Remove unused spec.go file
a8b465f 
Signed-off-by: Christian Haudum <[email protected]>
@chaudum
fixup! Remove n-gram length and n-gram skip
8870a90 
Signed-off-by: Christian Haudum <[email protected]>
@chaudum chaudum force-pushed the chaudum/cleanup-unused-bloom-code branch from e48d7bd to 8870a90 Compare September 19, 2024 14:24
@chaudum chaudum requested a review from rfratto September 19, 2024 14:35
@chaudum chaudum merged commit 2840d48 into main Sep 19, 2024
63 checks passed
@chaudum chaudum deleted the chaudum/cleanup-unused-bloom-code branch September 19, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfratto rfratto rfratto approved these changes

Assignees
No one assigned
Labels
size/XXL type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chaudum @rfratto